Fix crash with appInfo() reading past end of buffer #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bug because the APDU proxy does not send back any flags unless you use HAVE_BOLOS define when building the SDK for the device. This does not seem to be built in on the NANO S PLUS target. That means using appInfo() will crash because it assumes you get flags back but they are never sent. See supporting documentation and code here, - https://github.com/LedgerHQ/ledger-secure-sdk/blob/cb5cfae5750d57e4c03460c5c93098fea7a8abcb/include/sdk_apdu_commands.h#L8-L32 - https://github.com/LedgerHQ/ledger-secure-sdk/blob/cb5cfae5750d57e4c03460c5c93098fea7a8abcb/src/os_io_seproxyhal.c#L1156-L1161
|
@NullSoldier thanks for the contribution. It is not really necessary, as appFlags should be there. They are missed on the Rust bindings. PR adding them in ledger LedgerHQ/ledger-device-rust-sdk#198. Once merge, this should be fix automatically. I think the PR is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug because the APDU proxy does not send back any flags unless you use HAVE_BOLOS define when building the SDK for the device. This does not seem to be built in on the NANO S PLUS target. That means using appInfo() will crash because it assumes you get flags back but they are never sent.
See supporting documentation and code here,